fix(bio-research): download FASTQ files over HTTPS instead of HTTP#173
Open
tejas-dharani wants to merge 1 commit intoanthropics:mainfrom
Open
fix(bio-research): download FASTQ files over HTTPS instead of HTTP#173tejas-dharani wants to merge 1 commit intoanthropics:mainfrom
tejas-dharani wants to merge 1 commit intoanthropics:mainfrom
Conversation
ENA FTP paths were converted to plain HTTP URLs, meaning multi-GB genomic downloads had no transport-layer encryption. ENA supports HTTPS on the same paths. Changed http:// to https:// on line 343. Fixes anthropics#166
tejas-dharani
force-pushed
the
fix/bio-research-fastq-https
branch
from
c28aee5 to
9dcf05c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ncbi_utils.pybuilds FASTQ download URLs using plain HTTP:ENA returns FTP paths like
ftp.sra.ebi.ac.uk/vol1/fastq/...which get converted tohttp://ftp.sra.ebi.ac.uk/.... These are multi-GB genomic files downloaded with no transport encryption — content can be modified in transit.The ENA API query itself is correctly over HTTPS (line 314), but the actual file downloads are not.
Fix
Change
http://tohttps://on line 343. ENA supports HTTPS downloads on the same paths.Changes
bio-research/skills/nextflow-development/scripts/utils/ncbi_utils.pyline 343:http://→https://Testing
ENA HTTPS endpoint confirmed accessible. No behavior change beyond encrypted transport.
Closes #166